Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add load_vyi and loads_vyi #314

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add load_vyi and loads_vyi #314

wants to merge 3 commits into from

Conversation

charles-cooper
Copy link
Member

create an ABIContractFactory from a vyi file

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper
feat: add load_vyi and loads_vyi
97e3470 
create an ABIContractFactory from a vyi file
@charles-cooper
add tests
6b56b43
@AlbertoCentonze
Copy link
Contributor

AlbertoCentonze commented Sep 17, 2024 •
edited
Loading

Nice, why not allow load_partial to load from .vyi files instead of creating a new function?

@DanielSchiavini
Copy link
Collaborator

boa.loads(interface_code, is_interface=True) would be nice but not consistent with boa.loads_abi(abi)

@charles-cooper
Copy link
Member Author

Nice, why not allow load_partial to load from .vyi files instead of creating a new function?

requires some guessing to figure out if it's an interface or not, and as daniel pointed out it's consistent with load_abi

@charles-cooper charles-cooper marked this pull request as ready for review September 18, 2024 19:56
@DanielSchiavini
Copy link
Collaborator

This looks fine but it is still a different interface then #260
@bout3fiddy does this cover your use cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSchiavini DanielSchiavini DanielSchiavini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charles-cooper @AlbertoCentonze @DanielSchiavini